Skip to content

Fix dialog dismiss parsing in CLI#361

Open
bytes032 wants to merge 1 commit intovercel-labs:mainfrom
bytes032:fix/dialog-dismiss
Open

Fix dialog dismiss parsing in CLI#361
bytes032 wants to merge 1 commit intovercel-labs:mainfrom
bytes032:fix/dialog-dismiss

Conversation

@bytes032
Copy link

@bytes032 bytes032 commented Feb 3, 2026

What’s going on

The CLI help and README list dialog dismiss as a valid subcommand, but the dialog parser only handles accept. Any other value (including dismiss) falls into UnknownSubcommand and the CLI exits with an error.

Fix

Add a dismiss branch to the dialog parser to emit the correct command JSON:

{ "id": id, "action": "dialog", "response": "dismiss" }

This matches the existing protocol and runtime support:

Why this is safe

It only changes CLI parsing for dialog and doesn’t touch the protocol or Playwright behavior.

Testing

Not run (no CLI tests in repo).

@vercel
Copy link
Contributor

vercel bot commented Feb 3, 2026

@bytes032 is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant